Skip to content

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Sep 20, 2023

Automated release-prep through pdk-templates from commit a4130e5.
Please verify before merging:

@github-actions github-actions bot requested a review from a team as a code owner September 20, 2023 23:50
@github-actions github-actions bot added the maintenance Maintenance chores are typically excluded from changelogs label Sep 20, 2023
@mhashizume
Copy link
Contributor

Closing and reopening to kick tests

@mhashizume mhashizume closed this Sep 21, 2023
@mhashizume mhashizume reopened this Sep 21, 2023
@mhashizume
Copy link
Contributor

The static code analysis check is failing because of the commit summary. This is fine and I don't mind overriding it here, but sometime in the future we should update the Rake task for the check to include "Release prep" the way we do in the core modules: https://github.com/puppetlabs/puppetlabs-augeas_core/blob/f2aa3957da62c467d24f241b545333a3759fe8e6/rakelib/commits.rake#L10

@AriaXLi
Copy link
Contributor

AriaXLi commented Sep 21, 2023

The static code analysis check is failing because of the commit summary. This is fine and I don't mind overriding it here, but sometime in the future we should update the Rake task for the check to include "Release prep" the way we do in the core modules: https://github.com/puppetlabs/puppetlabs-augeas_core/blob/f2aa3957da62c467d24f241b545333a3759fe8e6/rakelib/commits.rake#L10

Just put up a PR for it since it seems like a quick fix! #669

@mhashizume
Copy link
Contributor

Closing and reopening this PR to incorporate the changes from #669

@mhashizume mhashizume closed this Sep 21, 2023
@mhashizume mhashizume reopened this Sep 21, 2023
@AriaXLi AriaXLi merged commit ffc0575 into main Sep 21, 2023
@AriaXLi AriaXLi deleted the release-prep branch September 21, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance chores are typically excluded from changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants