(BKR-147) add Gemfile setting for BEAKER_VERSION for puppet... #49
Conversation
puppetdb, etc - support for BEAKER_VERSION and BEAKER_RSPEC_VERSION in gemfile
| gem 'beaker-rspec', *location_for(beaker_rspec_version) | ||
| else | ||
| gem 'beaker-rspec', :require => false | ||
| end |
There was a problem hiding this comment.
Does beaker-rspec work on Windows? If no, this will need further shielding guarding.
There was a problem hiding this comment.
This PR doesn't change the exposure of Windows to beaker-rspec. ie it was installed before, and installation will still be attempted after this PR, it will just use more of Bundler's options when installing it. If the Gemfile didn't work before, it still won't work, if it worked before, it should continue to work.
There was a problem hiding this comment.
Yes, @justinstoller is correct. This doesn't alter the functionality/defaults of the Gemfile - just adds support for BEAKER_VERSION/BEAKER_RSPEC_VERSION.
There was a problem hiding this comment.
Let's keep it broken is not really a good statement folks. It's too easy to add :system_tests around this - it will make it consistent with other modules as well.
There was a problem hiding this comment.
Would you prefer to simply remove the beaker/beaker-rspec gem dependency until such time as there are acceptance level tests? If so, I'm cool with that. I was just folding the Gemfile under the new standard without really being concerned with the actual contents of that file.
There was a problem hiding this comment.
Actually, we can take this as is - let's just file something or followup with a fix.
There was a problem hiding this comment.
I'm not sure what the new standard is, I just saw that other gemfiles use :system_tests and thought that would be part of this change.
(BKR-147) add Gemfile setting for BEAKER_VERSION for puppet...
puppetdb, etc