Add a global password_encryption parameter #1584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function postgresql::password() looks at the default for encryption. If you want to use SCRAM on PostgreSQL < 14 then the default must be overridden, or specified for every use. This parameter allows it to be globally overridden.
ekohl
requested review from
alexjfisher,
bastelfreak,
deric,
SimonHoenscheid,
smortex and
a team
as code owners
bastelfreak
reviewed
Mar 26, 2024
| @@ -25,7 +25,7 @@ | |||
| $manage_selinux = pick($manage_selinux, false) | |||
| $package_ensure = 'present' | |||
| $module_workdir = pick($module_workdir,'/tmp') | |||
| $password_encryption = versioncmp($version, '14') ? { -1 => 'md5', default => 'scram-sha-256' } | |||
| $password_encryption = pick($password_encryption, versioncmp($version, '14') ? { -1 => 'md5', default => 'scram-sha-256' }) | |||
There was a problem hiding this comment.
Does that work? pick() refrences the variable itself? And line 21-24 follow the same pattern 🤔
should it be:
Suggested change
| $password_encryption = pick($password_encryption, versioncmp($version, '14') ? { -1 => 'md5', default => 'scram-sha-256' }) | |
| $password_encryption = pick($postgresql::globals::password_encryption, versioncmp($version, '14') ? { -1 => 'md5', default => 'scram-sha-256' }) |
There was a problem hiding this comment.
Yes, I was also surprised. I think it's (ab)using the parser a bit. I wanted to remain consistent.
There was a problem hiding this comment.
okay. so it's probably coming from globals. interesting. Not sure if that works on purpose or by accident :D
bastelfreak
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The function postgresql::password() looks at the default for encryption. If you want to use SCRAM on PostgreSQL < 14 then the default must be overridden, or specified for every use. This parameter allows it to be globally overridden.
Related Issues (if any)
Found in theforeman/foreman-installer#924 when testing out SCRAM support with PostgreSQL 13.
Checklist
puppet apply)