Update for compatibility with 2018.1.0 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npwalker
force-pushed
the
compat_with_2018.1
branch
5 times, most recently
from
bc0aba2 to
89da60d
Compare
npwalker
changed the title
npwalker
force-pushed
the
compat_with_2018.1
branch
from
89da60d to
699fad9
Compare
npwalker
force-pushed
the
compat_with_2018.1
branch
from
699fad9 to
44e7bb0
Compare
npwalker
force-pushed
the
compat_with_2018.1
branch
from
65d46ac to
b736313
Compare
npwalker
force-pushed
the
compat_with_2018.1
branch
from
b736313 to
e5c7644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow pe_databases to run on 2018.1.0, the module needs to stop managing
postgresql.confsettings as PE does it now withpuppet_enterprise::profile::database.This PR, adds a check for 2018.1 and stops including the postgresql_settings class if the version is greater than or equal to 2018.1.0.
postgresql_settings::table_settingsis still included by default and will continue to use parameters set on postgresql_settings if they were set in hiera.