Not compatible with 2018.1.0

[robertc99]

Module get the following error with PE 2018.1.0

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Service[postgresqld] is already declared at (file: /etc/puppetlabs/code/environments/production/modules/pe_databases/manifests/postgresql_settings.pp, line: 41); cannot redeclare (file: /opt/puppetlabs/puppet/modules/pe_postgresql/manifests/server/service.pp, line: 30) (file: /opt/puppetlabs/puppet/modules/pe_postgresql/manifests/server/service.pp, line: 30, column: 3) on node harmony3-p1.anu.edu.au

[npwalker]

@robertc99 in past version of PE we didn't manage postgresql settings during agent runs ( but did during upgrades or when invoking puppet infra configure ) now PE 2018.1. does manage database settings.

So I'd probably just do not manage database settings with this module and instead use what PE has built in. All the settings needed from this module should be in puppet_enterprise::profile::database, however, they may have slightly different defaults. If you have any questions on the differing defaults let me know.

class { 'pe_databases': 
  manage_postgresql_settings => false
}

class { 'pe_databases::postgresql_settings::table_settings : }

I said something similar over in #15 (comment)

I think what I will do is wrap the include of postgresql_settings in init.pp in a version check and then include postgresql_settings::table_settings directly in init.pp instead of at the bottom of postgresql_settings.

I'll probably get a new version out in a few days.

[robertc99]

I tried what you suggested. Still getting errors

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Class[Pe_databases::Postgresql_settings::Table_settings]:
parameter 'manage_fact_values_autovacuum_cost_delay' expects a Boolean value, got Undef
parameter 'manage_reports_autovacuum_cost_delay' expects a Boolean value, got Undef (file: /etc/puppetlabs/code/environments/puppet_upgrade_20180503/site/profile/manifests/puppetmaster_pe.pp, line: 12, column: 3) on node harmony3-p1.anu.edu.au

Any word on the updated version..

[npwalker]

@robertc99 I created #17 to allow the module to run on 2018.1.0. This means you will need to port whatever settings you prefer from this module into parameters on puppet_enterprise::profile::database.

[npwalker]

@robertc99 this should be resolved by the 0.14.0 release.