Does not support HA

[dylanratcliffe]

When a primary or secondary master is classified as so, there are many conflicts and a duplicate declaration that arise from the puppet_enterprise::profile::database class.

Ideas for fix:

• Not manage the settings if it's a HA master (Not great, as they are useful settings)
• Use a nasty hack to make the puppet_enterprise resources that conflict write to the wrong file
• Use a nasty hack to override the values that the resources are enforcing

Conflicting resources:

• /Stage[main]/Pe_databases::Postgresql_settings/Postgresql_conf[log_autovacuum_min_duration]
• /Stage[main]/Puppet_enterprise::Profile::Database/Pe_postgresql::Server::Config_entry[log_autovacuum_min_duration]/Pe_postgresql_conf[log_autovacuum_min_duration]
• /Stage[main]/Pe_databases::Postgresql_settings/Postgresql_conf[log_temp_files]
• /Stage[main]/Puppet_enterprise::Profile::Database/Pe_postgresql::Server::Config_entry[log_temp_files]/Pe_postgresql_conf[log_temp_files]
• /Stage[main]/Pe_databases::Postgresql_settings/Postgresql_conf[work_mem]
• /Stage[main]/Puppet_enterprise::Profile::Database/Pe_postgresql::Server::Config_entry[work_mem]/Pe_postgresql_conf[work_mem]
• /Stage[main]/Pe_databases::Postgresql_settings/Postgresql_conf[max_connections]
• /Stage[main]/Puppet_enterprise::Profile::Database/Pe_postgresql::Server::Config_entry[max_connections]/Pe_postgresql_conf[max_connections]

[npwalker]

To my knowledge, there's nothing managed in the postgresql_settings class that isn't managed by puppet_enterprise::profile::database.

I'd probably just do

class { 'pe_databases': 
  manage_postgresql_settings => false
}

class { 'pe_databases::postgresql_settings::table_settings : }

Although you might have to set the parameters on table_settings if postgresql_settings isn't included? I could add a pick() to the parameters if that's the case.

Since PE 2018.1 will include a PE database node group that includes the puppet_enterprise::profile::database class I can easily just stop managing the postgresql_settings based on version, however, I don't know how to make that decision based on whether it's an HA install or not.

[npwalker]

This should be compatible with HA in 2018.1.0 because it no longer manages postgresql settings in 2018.1.0.