Skip to content

(MODULES-11594) Fix SLES-15 nightly errors #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

(MODULES-11594) Fix SLES-15 nightly errors #1679

merged 1 commit into from
Jul 17, 2025

Conversation

shubhamshinde360
Copy link
Contributor

@shubhamshinde360 shubhamshinde360 commented Jul 11, 2025 •
edited
Loading

Summary

Fix SLES-15 nightly errors

Additional Context

  • Add skip-ssl flag to sles-15 tests since sles-15 is stricter when it comes to ssl checks.
  • Update references to mysql to mariadb since mysql gives a deprecation warning.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@shubhamshinde360 shubhamshinde360 force-pushed the MODULES-11594 branch 3 times, most recently from b83ee95 to 8293749 Compare July 17, 2025 06:37
@shubhamshinde360 shubhamshinde360 marked this pull request as ready for review July 17, 2025 07:14
@shubhamshinde360
Copy link
Contributor Author

The failures in deb based platforms and el-7 based platforms are due to unrelated issues which will be handled separately.

@shubhamshinde360
(MODULES-11594) Fix SLES-15 nightly errors
fe50af9 
 - Add false skip-ssl flag to sles-15 tests as sles-15 is using a mysql version that is stricter in terms of ssl checks.
 - Update references to mysql to be mysql or mariadb (depending on the platform) as mysql gives a deprecation warning in newer platforms.
amitkarsale
amitkarsale approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@amitkarsale amitkarsale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubhamshinde360 shubhamshinde360 merged commit 3cc1d4e into main Jul 17, 2025
20 of 40 checks passed
@shubhamshinde360 shubhamshinde360 deleted the MODULES-11594 branch July 17, 2025 11:58
@vchepkov
Copy link
Contributor

vchepkov commented Aug 1, 2025

This seems like an innocent change, but this will cause a database restart and an outage, because template injects an empty line into configuration file:

Notice: /Stage[main]/Mysql::Server::Config/File[mysql-config-file]/content: 
--- /etc/my.cnf.d/server.cnf	2024-07-28 11:50:48.188936299 +0000
+++ /tmp/puppet-file20250801-116628-91vw51	2025-08-01 11:51:58.909337917 +0000
@@ -2,6 +2,7 @@
 
 [client]
 port = 3306
+
 socket = /var/lib/mysql/mysql.sock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitkarsale amitkarsale amitkarsale approved these changes

@alexjfisher alexjfisher Awaiting requested review from alexjfisher alexjfisher is a code owner

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubhamshinde360 @vchepkov @amitkarsale