Skip to content

CAT-1147 erb to epp conversion #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

dinesh-gujar
Copy link
Contributor

@dinesh-gujar dinesh-gujar commented Jul 31, 2023

Summary

Conversion of ERB to EPP templates for mysql module

Additional Context

Related Issues (if any)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@malikparvez
Copy link
Member

can you squash your commits?

@Ramesh7
Copy link
Contributor

Ramesh7 commented Aug 2, 2023

Please update PR template.

@dinesh-gujar dinesh-gujar force-pushed the CAT-1147-conversion-erb-to-epp branch 2 times, most recently from 3f109db to 26c3eff Compare August 3, 2023 07:41
@dinesh-gujar dinesh-gujar force-pushed the CAT-1147-conversion-erb-to-epp branch from e1fa4b1 to dd9c4b2 Compare August 3, 2023 09:23
Copy link
Contributor

@Ramesh7 Ramesh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, waiting for CI to get 🟢

@Ramesh7 Ramesh7 merged commit 17b8244 into main Aug 3, 2023
@Ramesh7 Ramesh7 deleted the CAT-1147-conversion-erb-to-epp branch August 3, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants