Support PPA in deb822 format #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericgiquel
requested review from
a team,
bastelfreak and
smortex
as code owners
|
|
kenyon
approved these changes
Mar 12, 2024
3 tasks
3 tasks
|
There seems to be an extra leading $ character on L59 in manifests/ppa.pp main branch. |
kenyon
reviewed
Oct 17, 2024
|
@smortex is there a chance you could look at merging this PR (and the related one)? |
amitkarsale
force-pushed
the
ppa-deb822
branch
from
553f23b to
e03e701
Compare
|
Is this PR good the be merged, all checks are passing? |
Co-authored-by: Kenyon Ralph <[email protected]>
Co-authored-by: Kenyon Ralph <[email protected]>
amitkarsale
force-pushed
the
ppa-deb822
branch
from
e03e701 to
cd4653c
Compare
david22swan
approved these changes
Dec 10, 2024
malikparvez
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since Ubuntu 23.10,
add-apt-repositoryno longer creates a.listfile but a.sourcesfile (in deb822 format).Additional Context
Related Issues (if any)
Checklist
puppet apply)