Skip to content

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Mar 8, 2023

Currently untested, but having a PR makes it easier to consume in my test environment.

Fixes #2264

@puppet-community-rangefinder
Copy link

apache::mod::proxy_http2 is a class

that may have no external impact to Forge modules.

apache::vhost is a type

Breaking changes to this file WILL impact these 128 modules (exact match):
Breaking changes to this file MAY impact these 36 modules (near match):

apache::vhost::proxy is a type

that may have no external impact to Forge modules.

This module is declared in 176 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@ekohl ekohl force-pushed the mod_proxy_http2 branch 5 times, most recently from 80bf726 to 9e1f9a1 Compare April 25, 2023 12:30
@ekohl ekohl marked this pull request as ready for review April 26, 2023 10:30
@ekohl ekohl requested a review from a team as a code owner April 26, 2023 10:30
@ekohl
Copy link
Collaborator Author

ekohl commented Apr 26, 2023

This is now green and ready for review.

Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud
Copy link
Contributor

Hey @ekohl, can you rebase this PR just to make sure CI is happy enough is our current main build? I will be happy to merge once that is done.

@ekohl ekohl force-pushed the mod_proxy_http2 branch from 9e1f9a1 to 5c3a9ba Compare May 26, 2023 16:33
@ekohl
Copy link
Collaborator Author

ekohl commented May 26, 2023

Trivial rebase done.

@jordanbreen28
Copy link
Contributor

jordanbreen28 commented Jun 29, 2023

Apologies to ask again @ekohl.. can you rebase and I'll keep an eye and merge when ci is complete.
Hoping to get this module released before the end of the week.

ekohl added 4 commits June 29, 2023 14:56
This adds a module class to include the Apache module. For every vhost
it also inspects the configured proxy if the module is required.
@ekohl ekohl force-pushed the mod_proxy_http2 branch from 5c3a9ba to 1769dbd Compare June 29, 2023 12:56
@ekohl ekohl requested a review from smortex as a code owner June 29, 2023 12:56
@ekohl
Copy link
Collaborator Author

ekohl commented Jun 29, 2023

Rebased

Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. test failures unrelated

@jordanbreen28 jordanbreen28 merged commit 6ef5fbf into puppetlabs:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Apache module mod_proxy_http2

5 participants