-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add mod_proxy_http2 support #2393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
80bf726
to
9e1f9a1
Compare
This is now green and ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @ekohl, can you rebase this PR just to make sure CI is happy enough is our current main build? I will be happy to merge once that is done. |
Trivial rebase done. |
Apologies to ask again @ekohl.. can you rebase and I'll keep an eye and merge when ci is complete. |
This adds a module class to include the Apache module. For every vhost it also inspects the configured proxy if the module is required.
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. test failures unrelated
Currently untested, but having a PR makes it easier to consume in my test environment.
Fixes #2264