Skip to content

Support setting SSLProxyCipherSuite on mod_ssl #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Oct 13, 2022

While it is a parameter for apache::vhost, this allows setting it server wide just like SSLCipherSuite.

@ekohl ekohl requested a review from a team as a code owner October 13, 2022 12:19
@puppet-community-rangefinder
Copy link

apache::mod::ssl is a class

Breaking changes to this file WILL impact these 28 modules (exact match):
Breaking changes to this file MAY impact these 2 modules (near match):

This module is declared in 174 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

While it is a parameter for apache::vhost, this allows setting it server
wide just like SSLCipherSuite.
@ekohl ekohl force-pushed the support-ssl-proxy-cipher-suite branch from 1bbc341 to 4bd6143 Compare October 21, 2022 10:19
@ekohl
Copy link
Collaborator Author

ekohl commented Oct 21, 2022

Pushed a trivial rebase, no changes.

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 2af520e into puppetlabs:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants