add --top-scope-variables cli argument, fix #228 #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcmaw
reviewed
Jan 30, 2025
jcharaoui
force-pushed
the
top_scope_facts_cli
branch
from
da71597 to
f4a94d3
Compare
|
Removed an extra blank line. |
|
Not sure how to deal with this issue, though:
|
Manually adjusting the Metrics/MethodLength variable in the rubocop_todo.yml file should do the trick. Alternatively, you can run |
jcharaoui
force-pushed
the
top_scope_facts_cli
branch
from
f4a94d3 to
11a7127
Compare
|
I fixed the comment and regenerated the Rubocop config for the line length issue. |
jcharaoui
force-pushed
the
top_scope_facts_cli
branch
from
11a7127 to
58fd47f
Compare
|
Fixed the explicit namespace failure. Specs should now pass. Sorry for the churn here. |
danadoherty639
approved these changes
Feb 19, 2025
KlavsKlavsen
pushed a commit
to Obmondo/LinuxAid
that referenced
this pull request
May 8, 2025
…top scope variable, and later the lint:ignore can be remove when a new puppet-lint is released puppetlabs/puppet-lint#229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the
--top-scope-variablesCLI option that setsPuppetLint.configuration.top_scope_variables.Related Issues (if any)
#228
Checklist