Re-add Ruby 2.5 support #2686
Merged
Re-add Ruby 2.5 support #2686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Facter is a runtime dependency of Puppet. The Puppet 7 series uses Ruby 2.5 as its minimum Ruby version. Thor is a runtime dependency of Facter. Thor dropped Ruby 2.5 support with version 1.3.0. This commits sets Facter's Gemspec to use Thor < 1.3.0.
joshcooper
approved these changes
Mar 7, 2024
Contributor
joshcooper
left a comment
joshcooper
left a comment
There was a problem hiding this comment.
Since puppet#main requires ruby >= 3.1 https://github.com/puppetlabs/puppet/blob/62b1cd63e096c01883cc1a9e1a05b03d4497598d/.gemspec#L24, once puppet#7.x goes EOL, I'm thinking a future version of facter should require >= 3.1 too. Maybe Facter 5? Could you file an issue so we don't forget?
Contributor
|
Is this really correct? I'd expect bundler to figure out that it can't use thor 1.3 if they have the correct metadata. Or is Ruby 2.5's bundler broken? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We dropped support for Ruby 2.5 in Facter in #2674.
However, this broke compatibility with Puppetserver 7 in rare circumstances in which Facter 4.6.0/4.6.1 was being used in conjunction with Puppetserver < 7.9.0. Up until 7.9.0, Puppetserver used JRuby 9.2.y.z, which is compatible with MRI Ruby 2.5.
This PR reverts the changes made in #2674 and limits Thor to < 1.3.0, as newer versions drop support for Ruby 2.5.