(FACT-3192) facter -p --no-external-facts should not raise #2565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriaXLi
force-pushed
the
FACT-3192/--puppet_--no-external-facts
branch
4 times, most recently
from
47642dd to
5878498
Compare
AriaXLi
force-pushed
the
FACT-3192/--puppet_--no-external-facts
branch
4 times, most recently
from
f3d7d98 to
9e85402
Compare
Facter will raise an error saying `no-external-facts and external-dir options conflict: please specify only one` if the -p/--puppet and --no-external-facts options are used together. The -p option adds another directory to external-dir which causes Facter to think the --external-dir option was also passed in. This commit ensures -p and --no-external-facts can be used together without raising and --external-dir is either set to false or any explicitely passed in external directories. Spec tests are also added to ensure Facter behaves as expected.
AriaXLi
force-pushed
the
FACT-3192/--puppet_--no-external-facts
branch
from
9e85402 to
aeaf26b
Compare
joshcooper
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facter will raise an error saying
no-external-facts and external-dir options conflict: please specify only oneif the -p/--puppet and --no-external-facts options are used together. The -p option adds another directory to external-dir which causes Facter to think the --external-dir option was also passed in. This commit ensures -p and --no-external-facts can be used together without raising and --external-dir is either set to false or any explicitely passed in external directories and adds a spec test to test this behavior.