(FACT-3151) Ensure /etc/os-release can contain comments without raising #2563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriaXLi
force-pushed
the
FACT-3151
branch
4 times, most recently
from
d37e26c to
41c8aca
Compare
Comments are allowed in the /etc/os-release files (see this link for more information: https://www.man7.org/linux/man-pages/man5/os-release.5.html). This commit enables comments in /etc/os-releases files without raising an exception and adds a spec test to ensure Facter is behaving as expected. Fabiano Pires (fxpires) wrote the commit that allows comments in /etc/os-release files without raising an exception. Previously, Facter would raise an exception if there was a comment in the /etc/os-release files. Co-authored by: Fabiano Pires <[email protected]>
AriaXLi
changed the title
mhashizume
approved these changes
Apr 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments are allowed in the /etc/os-release files (see this link for more
information: https://www.man7.org/linux/man-pages/man5/os-release.5.html). This
commit enables comments in /etc/os-releases files without raising an exception
and adds a spec test to ensure Facter is behaving as expected.
Fabiano Pires (fxpires) wrote the commit (#2527) that allows comments in
/etc/os-release files without raising an exception. Previously, Facter would
raise an exception if there was a comment in the /etc/os-release files.