(maint) GitHub Actions maintenance #2541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub is deprecating Actions running Node12 this year: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ The Checkout Action uses Node12 in v2 and Node16 in v3. This commit updates all instances of the Checkout Action to use v3.
This commit updates all of the Ruby versions from end-of-life versions to Ruby 2.7.
mhashizume
force-pushed
the
maint/main/checkout_action
branch
from
7714ef7 to
e6e9d4b
Compare
The install_puppet_agent method in the Presuite Action blindly passes Bundler output as a file path to Beaker. However, the Bundler command can sometimes include other output (e.g. deprecation warnings) and cause Beaker to fail. This commit adds simple error handling to the install_puppet_agent method to deal with this condition.
On running the acceptance workflow, we get a warning about a bug in the currently running version of Rubygems (3.0.3.1) that affects other code in the workflow. This commit sets the Rubygems version in the acceptance workflow to 3.3.26, the same version of Rubygems that we use in Puppet GitHub Actions.
Prior to this commit, the monkeypatching for mocks was overwriting the win32/registry class but ommited the API module. This commit adds that module back.
mhashizume
force-pushed
the
maint/main/checkout_action
branch
from
115bb2c to
0532109
Compare
Contributor
Author
|
Added a few more commits to address a failing acceptance test that was blocking checks from passing and to fix the discrepancy between the macOS GitHub Actions runner (latest is shifting from macOS 11 to macOS 12). |
joshcooper
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: