(FACT-3172) Fix IPv6 unique-local unicast address filtering #2540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch? |
smortex
changed the title
smortex
changed the title
smortex
changed the title
smortex
force-pushed
the
fix-ipv6-unique-local-unicast-address-filtering
branch
from
64e5107 to
858d0d5
Compare
Contributor
Instead of String comparison, check if IP addresses are included into the ignored ranges. No functional change.
RFC4291 define the Link-local unicast range as fe80::/10, not fe80::/16. As a consequence some Link-local unicast addresses where not correctly filtered, e.g. fe87::. While here, add a "working" example with an actual global IPv6 address from the 2001:0DB8::/32 range reserved for documentation (RFC3849).
We do not want these addresses to be reported as the default IPv6 address in `networking.ip6`. Quoting RFC4193: > This document defines an IPv6 unicast address format that is globally > unique and is intended for local communications, usually inside of a > site. These addresses are not expected to be routable on the global > Internet.
smortex
force-pushed
the
fix-ipv6-unique-local-unicast-address-filtering
branch
from
858d0d5 to
40cdf79
Compare
joshcooper
approved these changes
Jan 6, 2023
Contributor
joshcooper
left a comment
joshcooper
left a comment
There was a problem hiding this comment.
Matches https://www.rfc-editor.org/rfc/rfc4193#section-3.2.1:
Prefix FC00::/7 prefix to identify Local IPv6 unicast
addresses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not want these addresses to be reported as the default IPv6 address in
networking.ip6. Quoting RFC4193:This PR also include: