(FACT-3133) allow echo for Windows custom facts
#2517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvpartytonight
force-pushed
the
FACT-3133
branch
2 times, most recently
from
a4631e3 to
d8966d0
Compare
tvpartytonight
changed the title
joshcooper
reviewed
Aug 29, 2022
tvpartytonight
force-pushed
the
FACT-3133
branch
2 times, most recently
from
7bb969c to
7dae57e
Compare
`echo` was supported for Windows in facter 3, but has been missing from support in facter 4; this change allows for custom facts to use the builtin echo commands in cmd.exe or powershell.
tvpartytonight
force-pushed
the
FACT-3133
branch
from
7dae57e to
a45c8a7
Compare
tvpartytonight
changed the title
echo for Windows custom facts
joshcooper
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.