Skip to content

Conversation

@jordanbreen28
Copy link
Contributor

This commit implements a dynamic checkout ref for the gem_ci workflow. This is because we will be updating the calling workflows to be run on the pull_request_target trigger so they can safely access secrets, so this extra checkout logic is needed in order to checkout the head branch.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

This commit implements a dynamic checkout ref for the gem_ci workflow.
This is because we will be updating the calling workflows to be run on
the pull_request_target trigger so they can safely access secrets, so
this extra checkout logic is needed in order to checkout the head
branch.
@jordanbreen28 jordanbreen28 marked this pull request as ready for review May 1, 2024 12:37
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner May 1, 2024 12:37
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 👍

@LukasAud LukasAud merged commit ff20433 into main May 1, 2024
@LukasAud LukasAud deleted the maint-update_checkout_ref_gem_ci branch May 1, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants