-
Notifications
You must be signed in to change notification settings - Fork 258
Modernize build dependencies and standardize version management #16838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Infrastructure updates: - Upgrade Node.js from v18 to v22 (.nvmrc) - Update GitHub Actions workflows to use Node 22 - Upgrade major dependencies: - AWS SDK: ^3.427.0 → ^3.738.0 - Octokit: v18/v4 → v21/v8 - postcss-purgecss: ^4.0.3 → ^7.0.0 - Update TypeScript configurations - Update build tooling (webpack, etc.) Markdownlint compatibility fixes: - Fix markdownlint v0.40.0 API compatibility (markdownlint/sync) - Implement hierarchical config system for flexible linting - Permissive base config for blog/marketing/tutorials content - Strict config for documentation (will be tuned separately) - Disable rules added in v0.25.0-v0.40.0 to maintain compatibility Build and lint now working with updated dependencies. Fixes #16259 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
|
Your site preview for commit 88491fc is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16838-88491fc8.s3-website.us-west-2.amazonaws.com. |
Fixes peer dependency warnings from @algolia/autocomplete packages. The search-insights package enables analytics tracking for Algolia autocomplete features. Resolves warnings introduced in dependency upgrade commit. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <[email protected]>
Add explicit accountName property to satisfy Azure naming requirements. Storage account names must match ^[a-z0-9]+$ (lowercase alphanumeric only, no hyphens). Without explicit accountName, Pulumi auto-generates a name that may include hyphens from the stack name, causing validation errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <[email protected]>
|
Your site preview for commit 63cad7b is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16838-63cad7bc.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit 6e9f949 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16838-6e9f949d.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit 53f4871 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16838-53f48719.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit 4ec8016 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16838-4ec80160.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit e4c07d3 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16838-e4c07d35.s3-website.us-west-2.amazonaws.com. |
Documentation Review - PR #16838This is a comprehensive modernization PR that updates runtime versions, dependencies, and adds significant new documentation. The changes are well-structured and follow best practices. SummaryScope: Runtime version updates (Node.js 18→22, Go 1.20→1.25, Hugo 0.135→0.151), dependency modernization (~30+ packages), and a new 3,696-line BUILD-AND-DEPLOY.md documentation file. Overall Assessment: ✅ Approved with minor suggestions The PR successfully modernizes the build infrastructure while maintaining stability. The addition of BUILD-AND-DEPLOY.md is particularly valuable as it fulfills the requirement from the updated docs-review guidelines. Strengths
Issues FoundCritical IssuesNone found. Style and Documentation Issues1. BUILD-AND-DEPLOY.md: Date Format InconsistencyLocation: BUILD-AND-DEPLOY.md:3 The date format "2025-12-16" uses an unusual format. According to STYLE-GUIDE.md and Google Developer Documentation Style Guide, dates should use "Month DD, YYYY" format. 2. BUILD-AND-DEPLOY.md: Command FormattingLocation: BUILD-AND-DEPLOY.md:38-39 For consistency with the Google Developer Documentation Style Guide, commands in text should be formatted as inline code, not just in code blocks. Current: make serve # Start local server at http://localhost:1313
make serve-all # Serve with asset rebuilding (webpack watch)This is actually fine as-is in a code block, but ensure that when commands are referenced in prose paragraphs throughout the document, they use inline code formatting like 3. .editorconfig: Missing Trailing NewlineLocation: .editorconfig:14 The file appears to be missing a trailing newline based on the style requirements in AGENTS.md ("Must always end with a newline"). Verify the file ends with a newline character. 4. Dependabot: Comment Could Be ClearerLocation: .github/dependabot.yml:21-23 The Prettier version pinning comment could be more specific about the issue. Verification Checklist✅ Spelling and grammar: No issues found Version Consistency CheckAll version updates are consistent across files:
Recommendations
ConclusionThis is a well-executed modernization PR. The infrastructure updates are systematic and consistent, and the addition of BUILD-AND-DEPLOY.md provides valuable documentation that will help future contributors and maintainers. The minor style issues noted above are cosmetic and don't block merging. Great work on this comprehensive update! Need additional reviews or fixes? Mention @claude and I'll be happy to help. |
Implementation Summary
Runtime Versions Updated
Dependencies Modernized
Key Implementation Decisions
transpileOnly: trueto ts-loader for TypeScript 3.9 compatibilitypurgeCSSPlugin) for v7.xrequire("markdownlint/sync").lint) for v0.40Approach: Conservative modernization - updated what needed updating (runtime versions + root/infra packages), preserved what was working (theme/Stencil).
Fixes #16259
Fixes #16274