-
Notifications
You must be signed in to change notification settings - Fork 252
Azure Page 4 Ads #15755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Azure Page 4 Ads #15755
Conversation
Your site preview for commit e801a37 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15755-e801a37b.s3-website.us-west-2.amazonaws.com. |
- changing language to Azure and ARM - changing code snippets from AWS to Azure
Your site preview for commit a1ee677 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15755-a1ee677e.s3-website.us-west-2.amazonaws.com. |
Why does the preview look empty?! |
Your site preview for commit 8155385 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15755-81553859.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit ec5475a is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15755-ec5475a5.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 01897ef is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15755-01897ef6.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 9864c79 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15755-9864c794.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, let's
…zure page to existing gads template
Updated the existing template to be extensible for any number of languages rather than hardcoded, so now azure can use the existing template (which moves this page from |
Your site preview for commit cbf6c80 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15755-cbf6c80b.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 35009b8 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15755-35009b8c.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -121,7 +121,12 @@ <h4>{{ $item.sub_title }}</h4> | |||
{{ end }} | |||
{{ if not (eq $item.ide nil) }} | |||
<div class="max-w-4xl container text-left card bg-white p-6 mx-auto"> | |||
<pulumi-chooser type="language" options="typescript,python,go,csharp,java,yaml"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this removed from the template? just trying to understand since i use this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asafashirov it's still there, it just generates the language tabs on the component dynamically from the content to be more extensible for pages that need more/less/different languages shown (this line is moved to line 129)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it- thanks!
@@ -191,7 +196,12 @@ <h4>{{ $item.sub_title }}</h4> | |||
{{ end }} | |||
{{ if not (eq $item.ide nil) }} | |||
<div class="max-w-4xl container text-left card bg-white p-6 mx-auto"> | |||
<pulumi-chooser type="language" options="typescript,python,go,csharp,java,yaml"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with this; why remove?
This is a landing page for ads, focusing on the Azure users.
Secondary: highlight C# and also ARM,