Skip to content

Conversation

SaraDPH
Copy link
Contributor

@SaraDPH SaraDPH commented Aug 15, 2025

This is a landing page for ads, focusing on the Azure users.
Secondary: highlight C# and also ARM,

@SaraDPH SaraDPH changed the title Add files via upload Azure Page 4 Ads Aug 15, 2025
@pulumi-bot
Copy link
Collaborator

- changing language to Azure and ARM
- changing code snippets from AWS to Azure
@SaraDPH SaraDPH added the area/www Enhancement and content requests for www.pulumi.com label Aug 15, 2025
@SaraDPH SaraDPH self-assigned this Aug 15, 2025
@pulumi-bot
Copy link
Collaborator

@SaraDPH
Copy link
Contributor Author

SaraDPH commented Aug 15, 2025

Why does the preview look empty?!

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

Copy link
Contributor

@CamSoper CamSoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, let's :shipit:

@SaraDPH SaraDPH requested a review from shughes26 August 20, 2025 14:37
@shughes26
Copy link
Contributor

Updated the existing template to be extensible for any number of languages rather than hardcoded, so now azure can use the existing template (which moves this page from /b/azure to /gads/azure

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

Copy link
Contributor

@asafashirov asafashirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like one of the the CTAs doesn't render properly:

Screenshot 2025-08-25 at 10 35 56 AM

@@ -121,7 +121,12 @@ <h4>{{ $item.sub_title }}</h4>
{{ end }}
{{ if not (eq $item.ide nil) }}
<div class="max-w-4xl container text-left card bg-white p-6 mx-auto">
<pulumi-chooser type="language" options="typescript,python,go,csharp,java,yaml">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this removed from the template? just trying to understand since i use this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asafashirov it's still there, it just generates the language tabs on the component dynamically from the content to be more extensible for pages that need more/less/different languages shown (this line is moved to line 129)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it- thanks!

@@ -191,7 +196,12 @@ <h4>{{ $item.sub_title }}</h4>
{{ end }}
{{ if not (eq $item.ide nil) }}
<div class="max-w-4xl container text-left card bg-white p-6 mx-auto">
<pulumi-chooser type="language" options="typescript,python,go,csharp,java,yaml">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with this; why remove?

@SaraDPH
Copy link
Contributor Author

SaraDPH commented Aug 25, 2025

Besides the button, the block with the code needs to be converted to an add markdown that allows me to add the Azure code.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/www Enhancement and content requests for www.pulumi.com
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants