Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,18 @@ function duplex (reader, read) {

if(read) {
s.sink(read)
s.paused = true

var on = s.on.bind(s)
s.on = (event, listener) => {
var res = on(event, listener)

if (event === 'data' && s.paused) {
next(s.resume.bind(s))
}

return res
}

var pipe = s.pipe.bind(s)
s.pipe = function (dest, opts) {
Expand Down
20 changes: 20 additions & 0 deletions test/data-event.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
var pull = require('pull-stream')
var duplex = require('../')

var test = require('tape')

test('should start to flow when data listener is added', function (t) {
var s = duplex(null, pull(pull.values(['hello'])))

setTimeout(() => {
s.on('data', (d) => {
t.equal(d, 'hello')
t.end()
})
}, 100)

setTimeout(() => {
t.fail('data event listener was not invoked')
t.end()
}, 200)
})
1 change: 1 addition & 0 deletions test/error.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ tape('test that error is emitted', function (t) {
t.equal(err, error)
t.end()
})
s.on('data', () => {})
})

tape('error when paused', function (t) {
Expand Down