Skip to content

python plugin can generate invalid python file names. #17950

@james-lawrence

Description

@james-lawrence

forgive me if i'm missing something obvious python is a language I rarely touch by choice so I might be missing something trivial.

What version of protobuf and what language are you using?
Version: 5.27.2
Language: python

What operating system (Linux, Windows, ...) and version?

uname -a
Linux 6.10.6-arch1-1 #1 SMP PREEMPT_DYNAMIC Mon, 19 Aug 2024 17:02:39 +0000 x86_64 GNU/Linux

What runtime / compiler are you using (e.g., python version or gcc version)
Python 3.12.4, setup a virtual env following the grpc quick start guide.

What did you do?
Steps to reproduce the behavior:

  1. create a proto file with the name example.service.proto
  2. generate python code using the proto file. .egpyenv/bin/python -m grpc_tools.protoc --python_out=. --pyi_out=. --grpc_python_out=. example.service.proto
  3. generated code will be named example.service_pb2.py and example.service_pb2_grpc.py respectively.
  4. can't import these files easily in python making them hard to use.

What did you expect to see
generated code that was usable. manually renaming the proto files is a possibility but the point of IDL tools is to handle these langauge specific divergent behaviors.

What did you see instead?
hard to import generated code.

Metadata

Metadata

Assignees

Labels

protocpythonuntriagedauto added to all issues by default when created.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions