fix: Revert "fix: 🐛 error should be thrown" #1864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e7a3489.
bcoe
approved these changes
Feb 2, 2023
Contributor
|
Okay, it does look like it's a problem. If I have time, I will investigate this problem again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1817
Cc: @binsee
This breaks the well established logic of proto loading (see #1863, I also see the problem in
google-gaxpackage). I suspect that the places that got broken are actually incorrect, but we cannot just break things like that even if we are making them work properly. So rolling back for now, we'll need to figure out the safer way of fixing the original problem.