Native histogram spec: Clarify counter reset handling for + and - #2707
+22
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krajorama is on vacation by now. @NeerajGartia21 and @juliusmh, your review would be very welcome so that we can close prometheus/prometheus#16576 . |
juliusmh
reviewed
Aug 15, 2025
docs/specs/native_histograms.md
Outdated
| counter reset hint. Otherwise, the resulting counter reset hint is set to | ||
| `UnknownCounterReset`. The result of a subtraction is always marked as a gauge | ||
| histogram because it might result in negative histograms, see [notes | ||
| above](#unary-minus-and-negative-histograms). In any case, adding or |
There was a problem hiding this comment.
Suggested change
| above](#unary-minus-and-negative-histograms). In any case, adding or | |
| above](#unary-minus-and-negative-histograms). Adding or |
I'm also wondering if we should keep this line, as there is no user-visible warning until reset merge algorithm is resolved.
There was a problem hiding this comment.
I have added a note, referring to the relevant section and issue.
Also, clarify that the same implications are valid for the `sum` and `avg` aggregation. Signed-off-by: beorn7 <[email protected]>
beorn7
force-pushed
the
beorn7/histogram
branch
from
21206e1 to
41b3c64
Compare
NeerajGartia21
approved these changes
Aug 18, 2025
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, clarify that the same implications are valid for the
sumandavgaggregation.Part of addressing prometheus/prometheus#16576 .
/cc @juliusmh