Implement Atomic<u64> for AtomicU64 for gauges #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobrik
force-pushed
the
ivan/atomic-u64
branch
from
bdfdae8 to
8b3b539
Compare
mxinden
reviewed
Oct 8, 2024
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Thinking about this some more, I think you are right, i.e. I think this is the right tradeoff.
Thank you for being persistent. Thanks for the thorough pull request.
Two minor comments, but otherwise this is good to go.
Also please add a changelog entry.
Between forcing end users to do endless `as i64` for things that are clearly `u64` and having one error case for rarely used protobuf when a gauge is set to `u64::MAX`, the latter seems like the right choice. Signed-off-by: Ivan Babrou <[email protected]>
bobrik
force-pushed
the
ivan/atomic-u64
branch
from
8b3b539 to
1ff3074
Compare
Contributor
Author
|
Updated. Please feel free adjust any text as you see fit. |
Signed-off-by: Max Inden <[email protected]>
mxinden
force-pushed
the
ivan/atomic-u64
branch
from
33cb1b6 to
0a00944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between forcing end users to do endless
as i64for things that are clearlyu64and having one error case for rarely used protobuf when a gauge is set tou64::MAX, the latter seems like the right choice.