-
Notifications
You must be signed in to change notification settings - Fork 103
build(deps): update prost-types requirement from 0.6 to 0.7 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the requirements on [prost-types](https://github.com/danburkert/prost) to permit the latest version. - [Release notes](https://github.com/danburkert/prost/releases) - [Commits](danburkert/prost@v0.6.0...v0.7.0) Signed-off-by: dependabot[bot] <[email protected]>
Contributor
Author
|
Looks like prost-types is up-to-date now, so this is no longer needed. |
mxinden
referenced
this pull request
in mxinden/client_rust
Aug 20, 2022
Make `encode` return iterator instead of vec
sd2k
added a commit
to sd2k/client_rust
that referenced
this pull request
Jan 20, 2025
This makes four changes: 1. The `EscapingScheme` and `ValidationScheme` enums are now `Copy` since they are very small and cheap to copy. They're passed by value rather than by reference. 2. The `escape_name` function now returns a `Cow` rather than a `String` to avoid allocations in many cases. 3. `escape_name` also preallocates a buffer for the escaped name rather than starting with an empty `String` and growing it, to amortize the allocations. 4. Use `is_ascii_alphabetic` and `is_ascii_digit` to check for characters that are valid in metric and label names. Based on profiles I suspect that prometheus#2 has the highest impact but haven't split these out to see how much of a difference it makes.
fedetorres93
pushed a commit
to fedetorres93/client_rust
that referenced
this pull request
Jan 22, 2025
This makes four changes: 1. The `EscapingScheme` and `ValidationScheme` enums are now `Copy` since they are very small and cheap to copy. They're passed by value rather than by reference. 2. The `escape_name` function now returns a `Cow` rather than a `String` to avoid allocations in many cases. 3. `escape_name` also preallocates a buffer for the escaped name rather than starting with an empty `String` and growing it, to amortize the allocations. 4. Use `is_ascii_alphabetic` and `is_ascii_digit` to check for characters that are valid in metric and label names. Based on profiles I suspect that prometheus#2 has the highest impact but haven't split these out to see how much of a difference it makes.
fedetorres93
pushed a commit
to fedetorres93/client_rust
that referenced
this pull request
Jan 22, 2025
This makes four changes: 1. The `EscapingScheme` and `ValidationScheme` enums are now `Copy` since they are very small and cheap to copy. They're passed by value rather than by reference. 2. The `escape_name` function now returns a `Cow` rather than a `String` to avoid allocations in many cases. 3. `escape_name` also preallocates a buffer for the escaped name rather than starting with an empty `String` and growing it, to amortize the allocations. 4. Use `is_ascii_alphabetic` and `is_ascii_digit` to check for characters that are valid in metric and label names. Based on profiles I suspect that prometheus#2 has the highest impact but haven't split these out to see how much of a difference it makes. Signed-off-by: Ben Sully <[email protected]>
fedetorres93
pushed a commit
to fedetorres93/client_rust
that referenced
this pull request
Jan 22, 2025
This makes four changes: 1. The `EscapingScheme` and `ValidationScheme` enums are now `Copy` since they are very small and cheap to copy. They're passed by value rather than by reference. 2. The `escape_name` function now returns a `Cow` rather than a `String` to avoid allocations in many cases. 3. `escape_name` also preallocates a buffer for the escaped name rather than starting with an empty `String` and growing it, to amortize the allocations. 4. Use `is_ascii_alphabetic` and `is_ascii_digit` to check for characters that are valid in metric and label names. Based on profiles I suspect that prometheus#2 has the highest impact but haven't split these out to see how much of a difference it makes. Signed-off-by: Ben Sully <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on prost-types to permit the latest version.
Release notes
Sourced from prost-types's releases.
Commits
b92b6derelease 0.7.0d79ad6fimprove compatibility with alpine6a4f12ainclude_file_descriptor_set -> file_descriptor_set_pathaa11ecbAddinclude_file_descriptor_settoprost-builda5bb7bfAdd prost-build::Config::disable_comments option (#389)32bb509bump bundled protobuf version to 3.14.0f482208bump rand dev dependency (#406)1db9167bump bytes to 1.0 (#405)423f5ecAdd bundled support for Mac aarch64 through Rosetta (#394)278e8abAdd up to date CI badge (#396)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)