Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expending a comment from #622 to a PR.
This PR proposes an API for recording exemplar values on counters and histograms.
Adds new
<inc|add>WithExemplar(double value, String... exemplarLabels)
methods which take string varargs containing exemplar values.Inspired by initial golang implementation by @beorn7 : prometheus/client_golang#706
Not addressed
Intentionally omitted
Counter#incWithExemplar(String... examplarLabels)
increment by 1 convenience method (less duplication in the API, forcing the user to include an amount felt reasonable if they're already using the more verbose method).@fstab @tomwilkie