Skip to content

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Sep 8, 2025

Fixes #1555

Note: also add the flag to protobuf writer

Signed-off-by: Gregor Zeitlinger <[email protected]>
Signed-off-by: Gregor Zeitlinger <[email protected]>
@fstab
Copy link
Member

fstab commented Sep 9, 2025

I think we should not continue with this before we have consensus in the Prometheus team on whether the exposition format should be determined at deploy time, or at scrape time via the Accept header. I put this on the agenda for the Prometheus dev summit.

If we decide on a deploy time config for suffixes we should at least allow users to explicitly use a suffix if they want. If a user explicitly creates a counter named requests_total it should not be renamed to requests, independent of config options.

Also note that some metric types like Histograms and Summaries will still require suffixes in text format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Otel Translation Strategies per spec

2 participants