fix(marker): stop state leakage from aggregation groups #4438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGKevin
reviewed
Aug 7, 2025
siavashs
force-pushed
the
marker-gc
branch
3 times, most recently
from
20c2483 to
cdff2d7
Compare
siavashs
force-pushed
the
marker-gc
branch
2 times, most recently
from
101e444 to
83a127e
Compare
siavashs
changed the title
SuperQ
reviewed
Oct 17, 2025
This change makes aggregation groups to delete resolved alerts from marker, therefore avoiding the leakage of ghost states mentioned in prometheus#4402. Signed-off-by: Siavash Safi <[email protected]>
Done, added 3 scenarios. The code is change to make sure that we don't accidentally delete a marker due to a race condition. Please have a look and let me know if we should add more. But while adding these I noticed the whole Marker setup to be a week point in terms of consistency, we need to come up with a better solution at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes aggregation groups to delete resolved alerts from marker, therefore avoiding the leakage of ghost states mentioned in #4402.
Fixes: #4402