Treat failure to collect metric as fatal #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this against master and sign off the DCO ( Also, if you wouldn't mind adding an entry to the CHANGELOG |
Exit on any failure to collect metrics. This will give `stackdriver_exporter` a chance to start over and perhaps recover from transient errors. For example: if it's Google credentials have expired and have been replaced, it can restart to try to load up new ones. Signed-off-by: Chris Pick <[email protected]>
cpick
force-pushed
the
fatal-collection-error
branch
from
c5c3b88 to
c49aace
Compare
|
Done and done. |
SuperQ
added a commit
that referenced
this pull request
May 14, 2020
* [CHANGE] Treat failure to collect metric as fatal #83 * [CHANGE] Switch logging to promlog #88 * [FEATURE] Add metrics prefix collect URL param #87 Signed-off-by: Ben Kochie <[email protected]>
Merged
This was referenced Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit on any failure to collect metrics. This will give
stackdriver_exportera chance to start over and perhaps recover fromtransient errors. For example: if it's Google credentials have expired
and have been replaced, it can restart to try to load up new ones.
Closes #66