Skip to content

setup exporter metrics only once when we can #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2022
Merged

setup exporter metrics only once when we can #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 50 additions & 26 deletions stackdriver_exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,35 +109,59 @@ func createMonitoringService(ctx context.Context) (*monitoring.Service, error) {
return monitoringService, nil
}

func newHandler(projectIDs []string, m *monitoring.Service, logger log.Logger) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
collectParams := r.URL.Query()["collect"]

// Create filters for "collect" query parameters.
filters := make(map[string]bool)
for _, param := range collectParams {
filters[param] = true
}
type handler struct {
handler http.Handler
logger log.Logger

registry := prometheus.NewRegistry()
projectIDs []string
m *monitoring.Service
}

for _, project := range projectIDs {
monitoringCollector, err := collectors.NewMonitoringCollector(project, m, filters, logger)
if err != nil {
level.Error(logger).Log("err", err)
os.Exit(1)
}
registry.MustRegister(monitoringCollector)
}
func (h *handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
collectParams := r.URL.Query()["collect"]
filters := make(map[string]bool)
for _, param := range collectParams {
filters[param] = true
}

if len(filters) > 0 {
h.innerHandler(filters).ServeHTTP(w, r)
return
}

h.handler.ServeHTTP(w, r)
}

func newHandler(projectIDs []string, m *monitoring.Service, logger log.Logger) *handler {
h := &handler{
logger: logger,
projectIDs: projectIDs,
m: m,
}

h.handler = h.innerHandler(nil)
return h
}

gatherers := prometheus.Gatherers{
prometheus.DefaultGatherer,
registry,
func (h *handler) innerHandler(filters map[string]bool) http.Handler {
registry := prometheus.NewRegistry()

for _, project := range h.projectIDs {
monitoringCollector, err := collectors.NewMonitoringCollector(project, h.m, filters, h.logger)
if err != nil {
level.Error(h.logger).Log("err", err)
os.Exit(1)
}
// Delegate http serving to Prometheus client library, which will call collector.Collect.
h := promhttp.HandlerFor(gatherers, promhttp.HandlerOpts{})
h.ServeHTTP(w, r)
registry.MustRegister(monitoringCollector)
}

gatherers := prometheus.Gatherers{
prometheus.DefaultGatherer,
registry,
}

// Delegate http serving to Prometheus client library, which will call collector.Collect.
return promhttp.HandlerFor(gatherers, promhttp.HandlerOpts{})
}

func main() {
Expand Down Expand Up @@ -172,9 +196,9 @@ func main() {
}

projectIDs := strings.Split(*projectID, ",")
handlerFunc := newHandler(projectIDs, monitoringService, logger)
handler := newHandler(projectIDs, monitoringService, logger)

http.Handle(*metricsPath, promhttp.InstrumentMetricHandler(prometheus.DefaultRegisterer, handlerFunc))
http.Handle(*metricsPath, promhttp.InstrumentMetricHandler(prometheus.DefaultRegisterer, handler))
http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
w.Write([]byte(`<html>
<head><title>Stackdriver Exporter</title></head>
Expand Down