fix converting NULL to uint64 is unsupported in size table #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolai Vaganov <[email protected]>
Signed-off-by: Nikolai Vaganov <[email protected]>
Signed-off-by: Nikolai Vaganov <[email protected]>
Electronn
force-pushed
the
fix-size-uint64-bug
branch
from
926fe58 to
20e1017
Compare
Sticksman
approved these changes
Oct 17, 2024
sysadmind
requested changes
Jan 1, 2025
| err := row.Scan(&segments, &size) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| var segmentsValue float64 |
There was a problem hiding this comment.
segments should never be NULL. It's a count(*) which I don't believe can return a NULL value. The error you reported was on the size column. If Aurora is returning NULL for that column, I think there should not be a metric emitted from the exporter. I don't know what value a metric for WAL size with a value of 0 is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes bug of unwanted null in uint64 type. Bug causes errors on AWS Aurora PostgreSQL clusters: