Skip to content

feat(RHOAIENG-25241): disable ray usage metrics by default #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kryanbeane
Copy link
Contributor

@kryanbeane kryanbeane commented May 15, 2025

Issue link

What changes have been made

Made RAY_USAGE_STATS_ENABLED default to = 0, which == disabled. Added unit tests to ensure enabledment and disablement. Also did manual testing and verified that a deployed custom build image has a default env var of RAY_USAGE_STATS_ENABLED = 0 on both head and worker pods

I verified that the env was present on the cluster

I also deployed a custom codeflare-sdk build on cluster and verified that /tmp/ray/session_xxx/usage_stats.json file does not exist. This is where ray temp writes usage stats to on the head.

Verification steps

  • Build custom image of codeflare-sdk (which goes to .dist folder)
  • Drag that to jupyter notebook in your cluster or locally, use it to install codeflare in notebook
  • Create a cluster (don't specify envs) and ensure head and workers have the env in place with a value of 0

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

openshift-ci bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chipspeak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kryanbeane kryanbeane force-pushed the RHOAIENG-25241 branch 2 times, most recently from e372843 to 891024f Compare May 15, 2025 21:02
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (028d0d5) to head (51f594a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
+ Coverage   92.45%   92.47%   +0.01%     
==========================================
  Files          24       24              
  Lines        1419     1421       +2     
==========================================
+ Hits         1312     1314       +2     
  Misses        107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kryanbeane kryanbeane force-pushed the RHOAIENG-25241 branch 3 times, most recently from 9be39bc to 48d93e1 Compare May 15, 2025 22:14
@kryanbeane kryanbeane marked this pull request as draft May 15, 2025 22:15
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2025
@kryanbeane kryanbeane force-pushed the RHOAIENG-25241 branch 2 times, most recently from 027dd08 to 036fa4b Compare May 16, 2025 07:58
@kryanbeane kryanbeane marked this pull request as ready for review May 16, 2025 08:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2025
@openshift-ci openshift-ci bot requested a review from Fiona-Waters May 16, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant