Skip to content

Remove hard-coded port 6443 in auth #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MichaelClifford
Copy link
Collaborator

Based on user feedback, we realized that hard coding the OpenShift server port was causing issues with some users preventing them from being able to log in.

This PR simple removes the :6443 suffix from server parameter so that the port must be explicitly included.

We can add future PR's to include some more sophisticated server address parsing and error handling.

Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should follow up with a PR later to make the server string logic a little more intelligent, something like

if len(self.server.split(":")) > 1:
    # Use server string
else:
   # User server string + :6443

Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@MichaelClifford MichaelClifford merged commit cf8f70e into project-codeflare:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants