Skip to content

Updated image parameter to be optional #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Bobbins228
Copy link
Contributor

@Bobbins228 Bobbins228 commented Jul 8, 2024

Issue link

Closes: RHOAIENG-9504

What changes have been made

Removed the validation function for the image parameter of the ClusterConfiguration

Verification steps

Setup

Notebook server ODH/RHOAI/Local

  • Clone this repository with git clone https://github.com/project-codeflare/codeflare-sdk.git
  • Checkout this PR's branch
  • Run poetry build - install if needed (pip install poetry)
  • Run pip install --force-reinstall dist/codeflare_sdk-0.0.0.dev0-py3-none-any.whl
  • Restart your notebook kernel

Testing

Test no image

Create a Ray Cluster while omitting image from the ClusterConfiguration.
The Ray Cluster's image should be quay.io/rhoai/ray:2.23.0-py39-cu121

Test with image

Create a Ray Cluster with the image parameter equating to any Ray compatible image e.g. quay.io/project-codeflare/ray:latest-py39-cu118
The Ray Cluster's image should be the image you set as the image parameter.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from KPostOffice and Maxusmusti July 8, 2024 09:33
Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
Copy link
Contributor

@VanillaSpoon VanillaSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed the provided instructions and achieved the expected results:

- image: quay.io/project-codeflare/ray:latest-py39-cu118

/lgtm

@Fiona-Waters
Copy link
Contributor

Ran through the steps and confirmed that it works as expected.
/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChristianZaccaria, Fiona-Waters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2a85469 into project-codeflare:main Jul 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants