Updated image parameter to be optional #582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Closes: RHOAIENG-9504
What changes have been made
Removed the validation function for the image parameter of the
ClusterConfiguration
Verification steps
Setup
Notebook server ODH/RHOAI/Local
git clone https://github.com/project-codeflare/codeflare-sdk.git
poetry build
- install if needed (pip install poetry
)pip install --force-reinstall dist/codeflare_sdk-0.0.0.dev0-py3-none-any.whl
Testing
Test no image
Create a Ray Cluster while omitting
image
from theClusterConfiguration
.The Ray Cluster's image should be
quay.io/rhoai/ray:2.23.0-py39-cu121
Test with image
Create a Ray Cluster with the image parameter equating to any Ray compatible image e.g.
quay.io/project-codeflare/ray:latest-py39-cu118
The Ray Cluster's image should be the image you set as the image parameter.
Checks