Make Local Queue label optional #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefanutti
reviewed
Jul 2, 2024
Bobbins228
force-pushed
the
local-queue-optional
branch
from
6ff0143 to
23879b9
Compare
astefanutti
reviewed
Jul 2, 2024
There was a problem hiding this comment.
Tested and works as expected:
- When not specifying LocalQueue in ClusterConfiguration but has default-queue annotation, LocalQueue label is added.
- When not specifying LocalQueue in ClusterConfiguration without the default-queue annotation, LocalQueue label is not added.
- When specifying the LocalQueue in ClusterConfiguration, LocalQueue label is added.
Thanks!
|
/lgtm |
Bobbins228
force-pushed
the
local-queue-optional
branch
from
23879b9 to
41b95ba
Compare
|
Rebased! |
|
/approve |
openshift-ci
bot
added
the
approved
|
@astefanutti @ChristianZaccaria I think the PR just requires a review approval in order to merge now :) |
astefanutti
approved these changes
Jul 3, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1ab5421
into
project-codeflare:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
closes: RHOAIENG-9348
What changes have been made
Altered the local_queue functionality so if no default local queue exists or
local_queueis not specified then the label will not be applied to the Ray Cluster.Verification steps
Setup
Notebook server ODH/RHOAI/Local
git clone https://github.com/project-codeflare/codeflare-sdk.gitpoetry build- install if needed (pip install poetry)pip install --force-reinstall dist/codeflare_sdk-0.0.0.dev0-py3-none-any.whlTesting
Remove Kueue from your OpenShift Cluster
RemovedClusterConfigurationwithout a local queue specified.Kueue is enabled but no default Local Queue exists
Checks