Add functions for accessing ray job logs #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelClifford
force-pushed
the
rayCommands
branch
4 times, most recently
from
151ad70 to
4fa4d09
Compare
Maxusmusti
requested changes
Jan 16, 2023
Collaborator
Maxusmusti
left a comment
Maxusmusti
left a comment
There was a problem hiding this comment.
It all LGTM, I would just add type hints and return types to the new function headers, then should be good to merge
MichaelClifford
force-pushed
the
rayCommands
branch
from
4fa4d09 to
45df01e
Compare
Contributor
Author
|
Thanks @Maxusmusti, added the type hints |
MichaelClifford
force-pushed
the
rayCommands
branch
from
45df01e to
4f62f91
Compare
Maxusmusti
requested changes
Jan 16, 2023
MichaelClifford
force-pushed
the
rayCommands
branch
from
4f62f91 to
c794536
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 3 new functions to the Cluster class
list_jobs,job_status,job_logsso that a user can get some insight into their submitted ray jobs.It also includes a clean up to
cluster_dashboard_urito prevent it from returning non-dashboard uri's