Skip to content

Added conditions before deleting template elements #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2023
Merged

Added conditions before deleting template elements #244

merged 2 commits into from
Aug 2, 2023

Conversation

Bobbins228
Copy link
Contributor

closes #206

MichaelClifford
MichaelClifford suggested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@MichaelClifford MichaelClifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but one issue with the way the last couple checks are done.

MichaelClifford
MichaelClifford reviewed Jul 26, 2023
View reviewed changes
MichaelClifford
MichaelClifford approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@MichaelClifford MichaelClifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MichaelClifford MichaelClifford merged commit 415b055 into project-codeflare:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maxusmusti Maxusmusti Awaiting requested review from Maxusmusti

1 more reviewer

@MichaelClifford MichaelClifford MichaelClifford approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for Template elements before deleting them in generate_yaml.py
2 participants
@Bobbins228 @MichaelClifford