Skip to content

add .venv and build directory to git ignore #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2023
Merged

add .venv and build directory to git ignore #179

merged 2 commits into from
Jul 6, 2023

Conversation

@KPostOffice
Copy link
Contributor

@KPostOffice KPostOffice commented Jun 26, 2023

Added poetry build directory to gitignore as well as any python venv directory starting with .venv

MichaelClifford
MichaelClifford approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@MichaelClifford MichaelClifford left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

But needs a rebase now. * actually nvm *

@MichaelClifford MichaelClifford merged commit 83910a8 into project-codeflare:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiripetrlik jiripetrlik Awaiting requested review from jiripetrlik

1 more reviewer

@MichaelClifford MichaelClifford MichaelClifford approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KPostOffice @MichaelClifford