Add support for image pull secrets for Ray Cluster images #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanillaSpoon
commented
Jun 16, 2023
VanillaSpoon
force-pushed
the
pull_secrets
branch
from
5019a34 to
15a6085
Compare
astefanutti
reviewed
Jun 21, 2023
VanillaSpoon
force-pushed
the
pull_secrets
branch
2 times, most recently
from
201105f to
e74f6d1
Compare
astefanutti
reviewed
Jun 22, 2023
VanillaSpoon
force-pushed
the
pull_secrets
branch
2 times, most recently
from
700d2b6 to
cead100
Compare
VanillaSpoon
force-pushed
the
pull_secrets
branch
from
cead100 to
14f7d89
Compare
Contributor
|
@VanillaSpoon Looks good! Thanks for the PR. The only comment that I have is that I don't think the *.html files are needed in here. We typically update all the docs at once prior to a new release. |
VanillaSpoon
force-pushed
the
pull_secrets
branch
from
14f7d89 to
7ba5dc3
Compare
Contributor
Author
|
Thanks @MichaelClifford, |
MichaelClifford
previously approved these changes
Jun 26, 2023
KPostOffice
reviewed
Jun 26, 2023
Contributor
KPostOffice
left a comment
KPostOffice
left a comment
There was a problem hiding this comment.
Tested on my cluster 👍🏻
One suggestion
dimakis
approved these changes
Jun 29, 2023
Contributor
dimakis
left a comment
dimakis
left a comment
There was a problem hiding this comment.
/lgtm
great work @VanillaSpoon 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
This pr adds the configuration to supply zero or more image pull secrets within the pod specification. Enabling access to private image registries.