Skip to content

Update dockerfile to start supporting multi-arch builds #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AjayJagan
Copy link
Contributor

Description

As a part of an effort to enable multi arch builds in konflux, we need to update the Dockerfile.

JIRA: https://issues.redhat.com/browse/RHOAIENG-28666

How Has This Been Tested?

Image built from konflux: quay.io/redhat-user-workloads/open-data-hub-tenant/codeflare-operator-multi-arch-poc:3adac4d93c0c4deedef5fdb484b6bdbccdfccb14

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Chores
    • Updated the Dockerfile to streamline the build process with a new base image and simplified build arguments, enhancing build efficiency without affecting application features or behavior.

@laurafitzgerald
Copy link
Contributor

Hi @dgrove-oss we're fine with this change. if you are good i'm happy to lgtm it.

@dgrove-oss
Copy link
Collaborator

Hi @dgrove-oss we're fine with this change. if you are good i'm happy to lgtm it.

Looks fine to me. Thanks!

@AjayJagan AjayJagan force-pushed the dockerfile-multiarch-upstream branch from 94ae6a7 to 54f5138 Compare July 10, 2025 18:03
@AjayJagan
Copy link
Contributor Author

@laurafitzgerald 👋 . Only the e2e fails , rest are okay

Co-authored-by: Bryan Keane <[email protected]>
@AjayJagan AjayJagan requested a review from kryanbeane July 10, 2025 19:26
@AjayJagan
Copy link
Contributor Author

@kryanbeane , every thing passed. Thanks 🙏

@AjayJagan
Copy link
Contributor Author

Can someone help me merge this please :) @kryanbeane @laurafitzgerald

@laurafitzgerald
Copy link
Contributor

/lgtm
/approve
after discussion with @dgrove-oss

Copy link

openshift-ci bot commented Jul 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: laurafitzgerald

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b696c86 into project-codeflare:main Jul 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants