-
Notifications
You must be signed in to change notification settings - Fork 66
Update dockerfile to start supporting multi-arch builds #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dockerfile to start supporting multi-arch builds #690
Conversation
Hi @dgrove-oss we're fine with this change. if you are good i'm happy to lgtm it. |
Looks fine to me. Thanks! |
94ae6a7
to
54f5138
Compare
@laurafitzgerald 👋 . Only the e2e fails , rest are okay |
Co-authored-by: Bryan Keane <[email protected]>
@kryanbeane , every thing passed. Thanks 🙏 |
Can someone help me merge this please :) @kryanbeane @laurafitzgerald |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laurafitzgerald The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b696c86
into
project-codeflare:main
Description
As a part of an effort to enable multi arch builds in konflux, we need to update the Dockerfile.
JIRA: https://issues.redhat.com/browse/RHOAIENG-28666
How Has This Been Tested?
Image built from konflux: quay.io/redhat-user-workloads/open-data-hub-tenant/codeflare-operator-multi-arch-poc:3adac4d93c0c4deedef5fdb484b6bdbccdfccb14
Merge criteria:
Summary by CodeRabbit