Update to AppWrapper v0.20.2 #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sutaakar
approved these changes
Jun 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 6bc0bc7
into
project-codeflare:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChristianZaccaria @sutaakar -- I believe this fixes the problem with a RayCluster wrapped in an AppWrapper being reset every 5 minutes (https://issues.redhat.com/browse/RHOAIENG-8834 and discussed in #521).
The problem is that ODH fork of Kueue sets
waitForPodsReady.enabledto true (https://github.com/opendatahub-io/kueue/blob/dev/config/components/manager/controller_manager_config.yaml#L25-L26) while the AppWrapper controller was assuming thatwaitForPodsReady.enabledwas false (which is the default in Kueue). As a result, the AppWrapper Job Reconciler loop was not updating thePodsReadycondition in the Workload object (this write is conditional on waitForPodsReady being true).We did a quick fix in AppWrapper 0.20.2. The right longer term fix is probably for the codeflare operator to read the Kueue configuration on startup so we can ensure that the two parts of the system are in synch.