Open examples in Processing #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for java-processing-faf822 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SableRaf
reviewed
Mar 25, 2025
src/components/OpenWithButton.js
Outdated
|
|
||
| const OpenWithButton = ({ pdes }) => { | ||
| const main = pdes[0] | ||
| let sketchURL = `pde://sketch/base64/${stringToBase64(main.code)}?pde=` |
There was a problem hiding this comment.
Doesnt this leave an extra ?pde= at the end of the URL?
There was a problem hiding this comment.
Is it necessary? Could we avoid it?
|
I made some changes to the styling and content of the tooltip and made it dismissable by clicking outside of it. @Stefterv: my code may not be the cleanest so feel free to make edits. 2025-03-27_14.56.00.2.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newest beta supports a new schema for opening Sketches in Processing from a link.
This PR adds an
Open With Processingbutton to all the examples on the website.2025-03-26.10.48.20.mp4