Skip to content

Conversation

@Zearin
Copy link
Contributor

@Zearin Zearin commented Dec 12, 2021

Typographically, "x" !== "×". ☻

Changes:
In comments, when referencing pixel dimensions or matrices, use “×” instead of “x”.

This does not include methods like p5.Matrix.prototype.invert3x3, where “x” is part of the API and cannot change. It’s only for “prose”.

PR Checklist

Much like `'' !== false` and `null !==  undefined`, the typographical equivalent is `"x" !== "×"`. ☻
@Zearin
Copy link
Contributor Author

Zearin commented Jan 2, 2022

ping

Copy link
Member

@lmccart lmccart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See note inline

@Zearin
Copy link
Contributor Author

Zearin commented Jan 13, 2022

@lmccart ping 🙂

@limzykenneth limzykenneth merged commit 196d3af into processing:main Jan 14, 2022
@limzykenneth
Copy link
Member

Looks good. Thanks!

@Zearin
Copy link
Contributor Author

Zearin commented Jan 15, 2022

🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants