fixing links to p5.MediaElement - resolves #5355 #5356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both createVideo and createAudio return p5.MediaElements, so the documentation is updated accordingly.
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
outofambit
approved these changes
Aug 18, 2021
Contributor
|
thank you for this fix @guilhermesilveira! and welcome! |
Contributor
|
@allcontributors please add @guilhermesilveira for doc |
Contributor
|
I've put up a pull request to add @guilhermesilveira! 🎉 |
This was referenced Feb 3, 2022
Open
This was referenced Mar 7, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both createVideo and createAudio return p5.MediaElements, so the documentation is updated accordingly.
Resolves #5355
Changes:
A simple documentation change that now points to p5.MediaElement in the website pages.
Screenshots of the change:
...
PR Checklist
(removed items that did not apply)