Convert exisiting translation files to new format #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getenJSON script generates the en.json file from the data.json file and the enJSONStaticStrings.json file.
English version of the Reference JSON files.
File containing the static strings of the Reference section that have to be inserted at the beginning of the en.json file.
Change the swapping of the text that has to translated, in order to match the new structure of the Reference JSON file.
Add script section that performs the text swaps in "class" pages of the Reference.
This reverts commit ab217d5.
This reverts commit 298060f.
yukienomiya
added a commit
to yukienomiya/p5.js-website
that referenced
this pull request
Aug 6, 2020
Changes made by @outofambit in the PR processing#835. Co-Authored-By: evelyn masso <[email protected]>
This was referenced Aug 7, 2020
Contributor
Author
|
superseded by #836 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based off of #803 so we can merge that PR and then this one right after.
(You can see the changes unique to this PR here 👀)
Changes:
es.jsonandzh-Hans.jsonto the new structureNotes:
Some of the existing translations did not quite match the current reference data in data.json. I ported as much as I could, but you'll see "UNKNOWN-PARAM" in about 30 places in each converted json file. Hopefully these will be easy to spot and update for translators.
cc/ @yukienomiya @lmccart and some past translators for spanish and chinese @limzykenneth @montoyamoraga @xinemata @lm-n (sorry if I missed someone!)