Skip to content

Add configurable option to ignore valid import check #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

SferaDev
Copy link
Contributor

@SferaDev SferaDev commented Sep 20, 2021

Markdown comments won't necessarily have a well-formed import expression, add an escape hatch for eslint configuration to ignore the valid import check.

Before merge, the readme for the rule should be updated to document this new flag.

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2021

⚠️ No Changeset found

Latest commit: 0a649eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@colebemis
Copy link
Contributor

Great minds think alike! I implemented a similar option in this PR: #7

@SferaDev
Copy link
Contributor Author

Cool! Superseded by #7.

Closing as yours has proper eslint rule schema, tests and the readme updated.

@SferaDev SferaDev closed this Sep 20, 2021
@SferaDev SferaDev deleted the allow-ignore-import branch September 20, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants