[no-deprecated-colors] Add skipImportCheck
option
#7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Memex has components that pass system props down to Primer React components (example).
If someone passes a deprecated to these wrapper components, the
no-deprecated-colors
rule won't notice it because it only looks at props passed to components imported from@primer/components
.Solution
In this PR, I added a
skipImportCheck
option. By default, theno-deprecated-colors
rule will only check for deprecated colors used in functions and components that are imported from@primer/components
. You can disable this behavior by settingskipImportCheck
totrue
. This is useful for linting custom components that that pass color-related props down to Primer React components.