Add Noto Sans to the body font stack
#2300
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To better support Linux.
🦋 Changeset detectedLatest commit: d451229 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vdepizzol
approved these changes
Nov 1, 2022
Contributor
|
Awesome! 🎉 🎉 Side note: we may also have to update this on Primer React and Primer Primitives (which should be used soon as a reference for both implementations) |
langermank
approved these changes
Nov 3, 2022
Contributor
langermank
left a comment
langermank
left a comment
There was a problem hiding this comment.
+1 adding this to Primitives!
Merged
9 tasks
6 tasks
pketh
added a commit
to kinopio-club/kinopio-client
that referenced
this pull request
Apr 26, 2024
> Hmm this appears to be a bug-by-design in the way Linux handles certain fonts like helvetica: chakra-ui/chakra-ui#2314 . Shipped a fix that specifies a Linux built-in font first: primer/css#2300 . Let me know if this works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This adds
Noto Sansto the$body-fontstack. I think the break down will be something like:-apple-systemfor Safari + Firefox on macOSBlinkMacSystemFontfor Chrome on macOSSegoe UIfor WindowsNoto Sansfor Linux ✨ new ✨Helveticaas legacy fallbackArialas legacy fallbacksans-serifas a system fallbackApple Color Emoji+Segoe UI Emojifor emojisWhat approach did you choose and why?
Adding
Noto Sansshould improve alignment issues on Linux. See #1209.What should reviewers focus on?
If anyone is on Linux and wants to test the new font stack, you could use the following in DevTools:
Can these changes ship as is?
Noto Sansto the font stack primitives#385